mihir174 commented on pull request #12095: URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747727943
Hey all, here are design revisions that I just discussed with @villebro and @junlincc to allow users to add saved metrics that are defined in the dataset - https://www.figma.com/file/JWaGztdhZS0kS5ruG7x9tB/Control-Panel?node-id=195%3A36068 <img width="1076" alt="Screen Shot 2020-12-17 at 1 56 57 PM" src="https://user-images.githubusercontent.com/64227069/102548591-bc527480-406f-11eb-9db7-5463bdbe8ee3.png";> Since there are 3 ways to add a metric, so it would be confusing if 2 or more of these ways were accessed from the same set of controls. Having one tab per way of adding seems like the most intuitive solution. @kgabryje ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/64227069/102548591-bc527480-406f-11eb-9db7-5463bdbe8ee3.png"](https://user-images.githubusercontent.com/64227069/102548591-bc527480-406f-11eb-9db7-5463bdbe8ee3.png"){kind=link}