villebro commented on a change in pull request #12095:
URL:
https://github.com/apache/incubator-superset/pull/12095#discussion_r545066622
##########
File path:
superset-frontend/spec/javascripts/explore/components/MetricsControl_spec.jsx
##########
@@ -150,138 +153,52 @@ describe('MetricsControl', () => {
});
describe('onChange', () => {
- it('handles saved metrics being selected', () => {
- const { wrapper, onChange } = setup();
- const select = wrapper.find(Select);
- select.simulate('change', [{ metric_name: 'sum__value' }]);
+ it('handles creating a new metric', () => {
+ const { component, onChange } = setup();
+ component.instance().onNewMetric({ metric_name: 'sum__value' });
Review comment:
We probably need to add the capability of selecting a saved
(=datasource) metrics in the "Simple" tab so that saved metrics show up in the
columns dropdown, and when selected, it hides the "Aggregate" select. Or some
other mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
