[GitHub] [incubator-superset] ktmud edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign

[GitBox]

ktmud edited a comment on pull request #12095:
URL: 
https://github.com/apache/incubator-superset/pull/12095#issuecomment-747936902


   Hi, finally got a chance to test this locally.  Some feedbacks on the UX:
   
   1. The focus state outline highlight got cut off:
      <img 
src="https://user-images.githubusercontent.com/335541/102589587-12510780-40c4-11eb-98d6-97565c0721a5.png";
 width="400">
   2. The metric pills for pre-defined metrics should show metric definition, 
either in a info icon tooltip or when clicked:
      <img 
src="https://user-images.githubusercontent.com/335541/102589867-8095ca00-40c4-11eb-8b93-b3226d597ff4.png";
 width="400">
   3.  @mihir174 what do you think of removing the "+" icon but always show the 
"Add metric" pill that is currently only used in the empty state. It's a little 
weird that two CTA living so close are basically doing the same thing.
   4. Custom SQL tab shows an empty brackets when entered without any column 
selection:
       <img 
src="https://user-images.githubusercontent.com/335541/102590493-863fdf80-40c5-11eb-9352-fed2bec2f78d.png";
 width="400">
   5. Can we please add drag & drop to sort the metrics soon? 
   
   Not sure if these are "known limitations", but I hope it got addressed soon. 
since this is not behind a feature flag, we basically can't deploy if the 
feature is incomplete (Good thing is we don't have to ship for at least another 
two weeks!)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org