michael-s-molina commented on a change in pull request #12059:
URL:
https://github.com/apache/incubator-superset/pull/12059#discussion_r545746558
##########
File path: superset-frontend/cypress-base/cypress/utils/vizPlugins.ts
##########
@@ -21,17 +21,20 @@ const V1_PLUGINS = ['box_plot', 'echarts_timeseries',
'word_cloud', 'pie'];
export const DASHBOARD_CHART_ALIAS_PREFIX = 'getJson_';
export function isLegacyChart(vizType: string): boolean {
- return !V1_PLUGINS.includes(vizType);
+ return V1_PLUGINS.indexOf(vizType) < 0;
Review comment:
I also prefer `includes` but this is only available in ES6 and our libs
in `tsconfig.json` only includes ES5. We can change to ES6, keep ES5 and also
add ES6 or use `indexOf`. What do you prefer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
