ktmud commented on a change in pull request #12059:
URL:
https://github.com/apache/incubator-superset/pull/12059#discussion_r545720749
##########
File path: superset-frontend/cypress-base/cypress/utils/vizPlugins.ts
##########
@@ -21,17 +21,20 @@ const V1_PLUGINS = ['box_plot', 'echarts_timeseries',
'word_cloud', 'pie'];
export const DASHBOARD_CHART_ALIAS_PREFIX = 'getJson_';
export function isLegacyChart(vizType: string): boolean {
- return !V1_PLUGINS.includes(vizType);
+ return V1_PLUGINS.indexOf(vizType) < 0;
Review comment:
+1 on `includes`! Would also prefer `new Set().has(...)` when it makes
sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
