ktmud commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553639022
##########
File path: .gitignore
##########
@@ -87,3 +87,5 @@ release.json
messages.mo
docker/requirements-local.txt
+
+superset/templates/custom_override_template.html
Review comment:
I don't think `.gitignore` is needed if the file is tracked anyway. You
could either:
1. Remove this file from `.gitignore`
2. Add it to `.gitignore` but delete the example file.
The name `custom_override_template` also sounds kind of generic (people may
expect it to override the whole page). How about `tail_js_extra.html`?
```jinja
{% block tail_js %}
{{ super() }}
{{ js_bundle("preamble") }}
{{ js_bundle('menu') }}
{#
This file may be overriden in your custom deployment.
It will be included in every view in superset and is a
good place to include your custom frontend code, such as
scripts to initialize google analytics, intercom, segment, etc.
#}
{% include "tail_js_extra.html" ignore missing %}
{% endblock %}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
