nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553652107
##########
File path: .gitignore
##########
@@ -87,3 +87,5 @@ release.json
messages.mo
docker/requirements-local.txt
+
+superset/templates/custom_override_template.html
Review comment:
The idea with adding the gitignore entry was so that
1. There is an example file
2. The file is tracked, but future changes to the file are not. This allows
users to add changes to the file without needing to commit those changes or
manage that diff.
3. Changes can be committed via `git add -f
superset/templates/custom_override_template.html` if necessary.
Though I see how this is could likely become source of confusion for those
unfamiliar with this pattern. I'll remove the gitignore entry.
How does `tails_js_custom_extra.html` sound? To me`tai_js_extra.html` sounds
like an internal name and not really like a vector for customization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
