[GitHub] [superset] codecov-io edited a comment on pull request #12524: fix(native-filters): Improve UI for long native filters names

Wed, 20 Jan 2021 04:03:44 -0800 


codecov-io edited a comment on pull request #12524:
URL: https://github.com/apache/superset/pull/12524#issuecomment-760350048


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12524?src=pr&el=h1) 
Report
   > Merging 
[#12524](https://codecov.io/gh/apache/superset/pull/12524?src=pr&el=desc) 
(df1abc7) into 
[master](https://codecov.io/gh/apache/superset/commit/e7a5d0d01abee3612c6a1e124e2286989c5ad1f6?el=desc)
 (e7a5d0d) will **decrease** coverage by `0.25%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/superset/pull/12524/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12524?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12524      +/-   ##
   ==========================================
   - Coverage   66.75%   66.50%   -0.26%     
   ==========================================
     Files        1015     1017       +2     
     Lines       49638    49741     +103     
     Branches     4839     4995     +156     
   ==========================================
   - Hits        33137    33078      -59     
   - Misses      16378    16539     +161     
   - Partials      123      124       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.00% <100.00%> (+0.01%)` | :arrow_up: |
   | javascript | `60.81% <100.00%> (+0.07%)` | :arrow_up: |
   | python | `63.47% <ø> (-0.50%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/superset/pull/12524?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==)
 | `53.52% <ø> (ø)` | |
   | 
[...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4)
 | `63.74% <100.00%> (+0.71%)` | :arrow_up: |
   | 
[superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5)
 | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=)
 | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==)
 | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
   | 
[superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5)
 | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5)
 | `95.74% <0.00%> (ø)` | |
   | 
[superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==)
 | `100.00% <0.00%> (ø)` | |
   | 
[...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==)
 | `73.77% <0.00%> (ø)` | |
   | ... and [47 
more](https://codecov.io/gh/apache/superset/pull/12524/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/superset/pull/12524?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/superset/pull/12524?src=pr&el=footer). 
Last update 
[e7a5d0d...df1abc7](https://codecov.io/gh/apache/superset/pull/12524?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to