[GitHub] [superset] agatapst commented on pull request #12524: fix(native-filters): Improve UI for long native filters names

[GitBox]

agatapst commented on pull request #12524:
URL: https://github.com/apache/superset/pull/12524#issuecomment-764497269


   @adam-stasiak Thanks for testing all the possible options. :) It seems ok 
now (see below). Can you check once again?
   I would stick with moving to the next line for now. As @junlincc wrote:
   > 3. Redesign modal layout(Propose stacking all the input and select fields 
in one column, increase the width of left panel by x% ) @mihir174 need design 
input
   > 4. after design for 3 is completed, we also need a solution for window 
resizing.
   > 
   there will be some improvements to the whole native filters layouts (after 
consultation with @mihir174), so I would suggest keep this PR to fix only 
problem with cutting/hiding/showing incorrectly very long filter names.
    
   <img width="1023" alt="Zrzut ekranu 2021-01-21 o 10 11 37" 
src="https://user-images.githubusercontent.com/47450693/105329669-b05b5480-5bd1-11eb-9eda-98391d71b553.png";>
   <img width="764" alt="Zrzut ekranu 2021-01-21 o 10 11 47" 
src="https://user-images.githubusercontent.com/47450693/105329681-b3564500-5bd1-11eb-8b68-3d3bc63547d2.png";>
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org