ktmud commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r562959206
##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
squash: true
merge: false
rebase: false
+
+ protected_branches:
+ master:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Docker/build
+ - Frontend/build
+ - PR Lint/check
+ - E2E/Cypress
+ - lint
+ - test-mysql
+ - test-postgres
+ - test-sqlite
Review comment:
<img width="917" alt="status-check-names"
src="https://user-images.githubusercontent.com/335541/105557505-46ba7380-5cc1-11eb-9195-38a912964f20.png";>
I'm assuming the API will use the same names as displayed here?
We might want to rename a couple of our jobs to avoid confusion (there are a
couple of duplicate "build"s).
I guess the safest route would be to have a very limited list here to
override the admin settings, then add them back in a separate PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/105557505-46ba7380-5cc1-11eb-9195-38a912964f20.png"](https://user-images.githubusercontent.com/335541/105557505-46ba7380-5cc1-11eb-9195-38a912964f20.png"){kind=link}