eschutho commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r562977674



##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
     squash: true
     merge: false
     rebase: false
+
+  protected_branches:
+    master:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Docker/build
+          - Frontend/build
+          - PR Lint/check
+          - E2E/Cypress
+          - lint
+          - test-mysql
+          - test-postgres
+          - test-sqlite

Review comment:
       The docs show them as `<Action Name>/<Job Name>`: 
   ```       
    contexts:
             - gh-infra/jenkins
             - another/build-that-must-pass
      ```
   although I realize that the action name was missing in some of the tests 
when I pulled them in, so I can update that. Looks to me that we would have to 
provide the action name in order for the duplicated job names to even work. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to