nytai commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r562974778
##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
squash: true
merge: false
rebase: false
+
+ protected_branches:
+ master:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Docker/build
+ - Frontend/build
+ - PR Lint/check
+ - E2E/Cypress
+ - lint
+ - test-mysql
+ - test-postgres
+ - test-sqlite
Review comment:
I think those are the names we need to use, though they do look quite
different than the names reported on PRs. I don't think the risk here is that
high, I doubt committers will be merging PRs with failing status checks (even
if they're not actually marked required). We could make and announcement just
in case, "You might see some changes to the required checks as we figure things
out, please don't merge anything that's failing a check"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
