[GitHub] [superset] codecov-io edited a comment on pull request #12705: feat(explore): allow opening charts with missing dataset

Sat, 23 Jan 2021 01:53:33 -0800 


codecov-io edited a comment on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-765819050


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=h1) 
Report
   > Merging 
[#12705](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=desc) 
(d2f47a4) into 
[master](https://codecov.io/gh/apache/superset/commit/0143a983b2b8e672f491c4a2c1f359e1c2b33c1f?el=desc)
 (0143a98) will **decrease** coverage by `8.01%`.
   > The diff coverage is `76.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/superset/pull/12705/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12705      +/-   ##
   ==========================================
   - Coverage   66.89%   58.88%   -8.02%     
   ==========================================
     Files        1020      963      -57     
     Lines       49905    47133    -2772     
     Branches     4888     4401     -487     
   ==========================================
   - Hits        33384    27753    -5631     
   - Misses      16396    19380    +2984     
   + Partials      125        0     -125     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.91% <66.66%> (+0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.41% <77.96%> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==)
 | `100.00% <ø> (ø)` | |
   | 
[...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==)
 | `100.00% <ø> (+4.76%)` | :arrow_up: |
   | 
[superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==)
 | `69.79% <0.00%> (ø)` | |
   | 
[superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5)
 | `89.49% <ø> (-1.83%)` | :arrow_down: |
   | 
[.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=)
 | `60.00% <50.00%> (-2.72%)` | :arrow_down: |
   | 
[superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==)
 | `75.31% <50.00%> (-0.11%)` | :arrow_down: |
   | 
[superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==)
 | `88.02% <66.66%> (-0.10%)` | :arrow_down: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.82% <68.00%> (-3.48%)` | :arrow_down: |
   | 
[superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==)
 | `90.16% <71.42%> (+0.76%)` | :arrow_up: |
   | 
[...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4)
 | `80.95% <100.00%> (-1.66%)` | :arrow_down: |
   | ... and [422 
more](https://codecov.io/gh/apache/superset/pull/12705/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=footer). 
Last update 
[0143a98...d2f47a4](https://codecov.io/gh/apache/superset/pull/12705?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to