ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563973045
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -164,16 +169,22 @@ class DatasourceControl extends React.PureComponent {
</Menu>
);
- // eslint-disable-next-line camelcase
const { health_check_message: healthCheckMessage } = datasource;
return (
<Styles className="DatasourceControl">
<div className="data-container">
<Icon name="dataset-physical" className="dataset-svg" />
- <Tooltip title={datasource.name}>
- <span className="title-select">{datasource.name}</span>
- </Tooltip>
+ {/* Add a tooltip only for long dataset names */}
+ {datasource.name.length > 20 ? (
Review comment:
This ideally should be more sophisticated where we display tooltip only
when we detect text has been cutoff. This is just a heuristic number that works
for the smallest panel width (300px).
It's a very local feature so I wouldn't put it into another file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
