ktmud commented on a change in pull request #12705:
URL: https://github.com/apache/superset/pull/12705#discussion_r563976755
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -196,6 +207,35 @@ class DatasourceControl extends React.PureComponent {
</Tooltip>
</Dropdown>
</div>
+ {/* missing dataset */}
+ {datasource.id == null && (
+ <div className="error-alert">
+ <ErrorAlert
+ level="warning"
+ title={t('Missing dataset')}
+ source="explore"
+ subtitle={
+ <>
+ <p>
+ {t(
+ 'The dataset linked to this chart may have been
deleted.',
Review comment:
My thinking is this: the dataset does not exist for two reasons, either
it never existed or has been deleted. Since the latter is the most likely case,
we inform users about this possibility, but also show reservations with "may"
to be more accurate.
I think a little bit more color in copy is more helpful comparing to
repeating the same general message over and over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
