etr2460 commented on pull request #13144: URL: https://github.com/apache/superset/pull/13144#issuecomment-779963705
Thanks for the context @willbarrett! Adding this to the PR summary would definitely be helpful (especially since they're not used anywhere in code, and therefore might get deleted as unused code in the future without that documentation). Also, for this use case, I wonder if the CSS (and even images with base64) should be embedded within the html files to prevent further dependencies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
