samtfm commented on pull request #13144: URL: https://github.com/apache/superset/pull/13144#issuecomment-782388351
@ktmud thank you for the suggestion! I've refactored this using html-webpack-plugin to render these html files directly to the distribution folder. I'm leaving the css hard coded into each html file for now, because fully embedding it from a separate file would require _even more_ complications to the webpack config, and I think this is fine enough for now with just these two pages. (package-lock.json got updated in a big way that I didn't intend, I am currently looking into how to tell npm to add a package without doing this lockfileVersion update) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
