rusackas commented on a change in pull request #13319:
URL: https://github.com/apache/superset/pull/13319#discussion_r582418730
##########
File path:
superset-frontend/spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx
##########
@@ -134,7 +134,7 @@ describe('Tabs', () => {
const wrapper = setup({ editMode: true, onChangeTab });
wrapper
.find(
- '[data-test="dashboard-component-tabs"] .ant-tabs-tab
[data-test="short-link-button"]',
+ '[data-test="dashboard-component-tabs"] .ant-tabs-tab [role="button"]',
Review comment:
Curious the impetus for this lil' change. In this instance, it's a
relatively minor example of a pattern question. I like the data-attributes as
it helps us quickly find the (potentially) offending DOM node when a test fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
