rusackas commented on a change in pull request #13319:
URL: https://github.com/apache/superset/pull/13319#discussion_r583088130
##########
File path:
superset-frontend/spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx
##########
@@ -134,7 +134,7 @@ describe('Tabs', () => {
const wrapper = setup({ editMode: true, onChangeTab });
wrapper
.find(
- '[data-test="dashboard-component-tabs"] .ant-tabs-tab
[data-test="short-link-button"]',
+ '[data-test="dashboard-component-tabs"] .ant-tabs-tab [role="button"]',
Review comment:
Fair enough. I like the data-test pattern mainly because if we see an
error in CI, it makes it trivial to find the relevant lines of code (which has
been handy with Cypress in particular). This case has a data-test attribute in
it anyway, so I'm not worried here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
