michael-s-molina commented on a change in pull request #13319:
URL: https://github.com/apache/superset/pull/13319#discussion_r582753506
##########
File path:
superset-frontend/spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx
##########
@@ -134,7 +134,7 @@ describe('Tabs', () => {
const wrapper = setup({ editMode: true, onChangeTab });
wrapper
.find(
- '[data-test="dashboard-component-tabs"] .ant-tabs-tab
[data-test="short-link-button"]',
+ '[data-test="dashboard-component-tabs"] .ant-tabs-tab [role="button"]',
Review comment:
This change is inspired by React Testing Library principles of
accessibility and [query
priority](https://testing-library.com/docs/queries/about/#priority). From an
accessibility standpoint, the user cannot see or hear test ids so that's why I
changed to `role="button"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
