craig-rueda commented on issue #13351: URL: https://github.com/apache/superset/issues/13351#issuecomment-793177990
To build on Rob's point above, I'd like to add that, I've noticed several migrations that do things like call `commit()` on their current session multiple times (usually in a loop), which breaks the atomic guarantee of migrations. I'm sure Alembic wraps the current session and intercepts calls to `commit()` under the covers, but we should still be checking for this sort of thing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
