simcha90 commented on a change in pull request #13484:
URL: https://github.com/apache/superset/pull/13484#discussion_r590170803
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -104,17 +104,21 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
// @ts-ignore
const hasDatasource = !!nativeFilterItems[formFilter?.filterType]?.value
?.datasourceCount;
+ const hasColumn =
+ hasDatasource &&
+ !['filter_timegrain',
'filter_timecolumn'].includes(formFilter?.filterType);
Review comment:
1. I think need move it to `consts`
2. May be we can do it a little bit common, like per some metadata value or
I think we need generate it by `controlPanel` value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
