villebro commented on a change in pull request #13484:
URL: https://github.com/apache/superset/pull/13484#discussion_r590174700
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -104,17 +104,21 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
// @ts-ignore
const hasDatasource = !!nativeFilterItems[formFilter?.filterType]?.value
?.datasourceCount;
+ const hasColumn =
+ hasDatasource &&
+ !['filter_timegrain',
'filter_timecolumn'].includes(formFilter?.filterType);
Review comment:
Good idea, I'll move it to to constants. This is still pending a
discussion around how much in common filter configs should have with the
explore control panel, but for now a constant lookup should be ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
