robdiciuccio commented on a change in pull request #14291:
URL: https://github.com/apache/superset/pull/14291#discussion_r618616090
##########
File path: superset/utils/core.py
##########
@@ -1065,6 +1065,9 @@ def to_adhoc(
elif expression_type == "SQL":
result.update({"sqlExpression": filt.get(clause)})
+ deterministic_name = md5_sha_from_dict(result)
+ result["filterOptionName"] = deterministic_name
Review comment:
I'm unclear what the impact of changing the `filterOptionName` value is
here. @rusackas @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
