robdiciuccio commented on a change in pull request #14291:
URL: https://github.com/apache/superset/pull/14291#discussion_r618617712
##########
File path: superset/tasks/async_queries.py
##########
@@ -91,6 +92,13 @@ def load_explore_json_into_cache( # pylint:
disable=too-many-locals
ensure_user_is_set(job_metadata.get("user_id"))
datasource_id, datasource_type = get_datasource_info(None, None,
form_data)
+ # Perform a deep copy here so that below we can cache the original
+ # value of the form_data object. This is necessary since the viz
+ # objects modify the form_data object. If the modified version were
+ # to be cached here, it will lead to a cache miss when clients
+ # attempt to retrieve the value of the completed async query.
+ original_form_data = copy.deepcopy(form_data)
Review comment:
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
