benjreinhart commented on a change in pull request #14291:
URL: https://github.com/apache/superset/pull/14291#discussion_r619403095
##########
File path: superset/utils/core.py
##########
@@ -1065,6 +1065,9 @@ def to_adhoc(
elif expression_type == "SQL":
result.update({"sqlExpression": filt.get(clause)})
+ deterministic_name = md5_sha_from_dict(result)
+ result["filterOptionName"] = deterministic_name
Review comment:
Hmm... can you point to a specific example of where that might be an
issue? Wouldn't each filter have different attributes? If not, is it a bug on
the client that the same filters for the same chart would be added more than
once? The idea is this should be deterministic for the same filter value, but
the set of filters should have different properties, causing a different sha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
