benjreinhart commented on pull request #14291: URL: https://github.com/apache/superset/pull/14291#issuecomment-828039158
Following up on this: I just spent some time playing with the UI and poking through the code. I am pretty confident the `filterOptionName` change will not cause issues (at least with how things are written today). If you filter out tests and superset/examples, there's only 14 references across the front and back end. As mentioned above, the only way I see a conflict is if two adhoc filters contained the exact same key/value pairs, which I don't think is an expected / desired use case to support. I think we're good on dashboards too since the filter handling should be scoped to a single chart. FWIW, I tested adding a duplicate filter pair, running the chart query, saving the chart, reloading it, etc., and it worked as expected. cc @robdiciuccio @villebro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
