AAfghahi commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r621725519
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -502,21 +506,76 @@ export default class ResultSet extends
React.PureComponent<
}
renderRowsReturned() {
- const { results, rows, queryLimit } = this.props.query;
+ const { results, rows, queryLimit, limitingFactor } = this.props.query;
const limitReached = results?.displayLimitReached;
+ let limitMessage;
+ const appContainer = document.getElementById('app');
+ const bootstrapData = JSON.parse(
+ appContainer?.getAttribute('data-bootstrap') || '{}',
Review comment:
Of course! I did it this way because this is how user was accessed
earlier in the file:
https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/ResultSet.tsx#L321
should I amend both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
