eschutho commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r622308221
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -502,21 +506,76 @@ export default class ResultSet extends
React.PureComponent<
}
renderRowsReturned() {
- const { results, rows, queryLimit } = this.props.query;
+ const { results, rows, queryLimit, limitingFactor } = this.props.query;
const limitReached = results?.displayLimitReached;
+ let limitMessage;
+ const appContainer = document.getElementById('app');
+ const bootstrapData = JSON.parse(
+ appContainer?.getAttribute('data-bootstrap') || '{}',
+ );
+ const isAdmin = bootstrapData.user?.roles?.hasOwnProperty('Admin');
+ const defaultDropwdown =
+ limitingFactor === 'DROPDOWN' && queryLimit === 1000;
Review comment:
can we put 1000 into a const as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
