AAfghahi opened a new pull request #14381: URL: https://github.com/apache/superset/pull/14381
### SUMMARY We wanted more robust messaging in Sql Lab that tells user what, if anything, is limiting the results that they get when they run a SQL query. Currently this file will also include a database migration, we are going to wait for this migration to resolve before we continue with this PR. This has custom messages that are based on: - DISPLAY_MAX_ROW causing the results to be limited (admin and non-admin messaging) - The query itself limiting the options - the dropdown limiting results - the default dropdown of 1000 being the cause for the limit ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before:  After: display max row for admin  non-admin  Query Limit  Dropdown limit:  Default Dropdown limit of 1000  ### TEST PLAN Visual Testing ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
