pkdotson commented on a change in pull request #14184:
URL: https://github.com/apache/superset/pull/14184#discussion_r625368761
##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -92,16 +105,108 @@ const StyledHeader = styled.header`
flex-direction: column;
justify-content: center;
}
-
- .nav > li > a {
+ @media (max-width: 767px) {
+ .navbar-brand {
+ float: none;
+ }
+ }
+ .ant-menu-horizontal .ant-menu-item {
+ height: 100%;
+ line-height: inherit;
+ }
+ .ant-menu > .ant-menu-item > a {
padding: ${({ theme }) => theme.gridUnit * 4}px;
}
+ @media (max-width: 767px) {
+ .ant-menu > .ant-menu-item > a {
+ padding: 0px;
+ }
+ .main-nav .ant-menu-submenu-title > svg:nth-child(1) {
+ display: none;
+ }
+ .ant-menu-item-active > a {
+ &:hover {
+ color: ${({ theme }) => theme.colors.primary.base} !important;
+ background-color: transparent !important;
+ }
+ }
+ }
.dropdown-header {
text-transform: uppercase;
padding-left: 12px;
}
+ .ant-menu-horizontal:not(.ant-menu-dark) > .ant-menu-submenu,
+ .ant-menu-horizontal:not(.ant-menu-dark) > .ant-menu-item {
+ margin: 0px;
+ &:hover {
+ border-bottom: none;
+ }
+ }
+ .ant-menu-horizontal > .ant-menu-item,
+ .ant-menu-horizontal > .ant-menu-submenu {
+ vertical-align: inherit;
+ &:hover {
+ color: ${({ theme }) => theme.colors.grayscale.dark1};
+ }
+ }
+ .navbar-right {
+ border: none;
+ }
+ .ant-menu-horizontal {
+ line-height: 51px;
Review comment:
With this one ant-d is using a line-height on the menu items when
horizontal. I'm overriding it by several pixels to get it to align better with
the logo. It look off with the default 46px.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
