pkdotson commented on a change in pull request #14184:
URL: https://github.com/apache/superset/pull/14184#discussion_r628544805
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -16,35 +16,65 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React, { ReactNode } from 'react';
+import React, { ReactNode, useState, useEffect } from 'react';
import { Link, useHistory } from 'react-router-dom';
import { styled } from '@superset-ui/core';
import cx from 'classnames';
-import { Nav, Navbar } from 'react-bootstrap';
+import { debounce } from 'lodash';
+import { Col, Row } from 'antd';
+import { Menu, MenuMode } from 'src/common/components';
import Button, { OnClickHandler } from 'src/components/Button';
-const StyledHeader = styled.header`
+const StyledHeader = styled.div`
margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
- .navbar {
- margin-bottom: 0;
- }
- .navbar-header .navbar-brand {
+ .header {
font-weight: ${({ theme }) => theme.typography.weights.bold};
margin-right: ${({ theme }) => theme.gridUnit * 3}px;
+ text-align: left;
+ font-size: 18px;
+ padding: ${({ theme }) => theme.gridUnit * 3}px;
+ display: inline-block;
+ line-height: ${({ theme }) => theme.gridUnit * 9}px;
}
- .navbar-right {
+ .nav-right {
display: flex;
align-items: center;
- padding: 8px 0;
+ padding: 14px 0;
+ margin-right: ${({ theme }) => theme.gridUnit * 3}px;
+ float: right;
+ }
+ .nav-right-collapse {
+ display: flex;
+ align-items: center;
+ padding: 14px 0;
margin-right: 0;
+ float: left;
+ padding-left: 10px;
+ }
+ .menu {
+ background-color: white;
+ .ant-menu-horizontal {
+ line-height: inherit;
+ .ant-menu-item {
+ &:hover {
+ border-bottom: none;
+ }
+ }
+ }
+ .ant-menu {
+ padding: ${({ theme }) => theme.gridUnit * 4}px 0px;
+ }
}
- .navbar-nav {
+
+ .ant-menu-horizontal:not(.ant-menu-dark) > .ant-menu-item {
Review comment:
Another override, because the default on the items were to large
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
