pkdotson commented on a change in pull request #14184:
URL: https://github.com/apache/superset/pull/14184#discussion_r628552291
##########
File path: superset-frontend/stylesheets/superset.less
##########
@@ -582,3 +582,35 @@ hr {
background-image: url('../images/icons/error_solid_small_red.svg')
!important;
background-position: -2px center !important;
}
+
+// Ant-d overrides since these are injected as inline styles and can't
+// be overrided in emotion
+.ant-menu-submenu.ant-menu-submenu-popup.ant-menu.ant-menu-light.ant-menu-submenu-placement-bottomLeft
{
+ top: 51px !important;
+ margin-left: -2px !important;
+ @media (max-width: 767px) {
+ top: 269px !important;
+ }
+ & > .ant-menu {
+ border-radius: 0px !important;
+ }
+}
+
+.ant-menu-submenu.ant-menu-submenu-popup.ant-menu.ant-menu-light {
+ top: 51px !important;
+ border-radius: 0px !important;
+ @media (max-width: 767px) {
+ top: 269px !important;
Review comment:
The only thing that will cause issue is when the if a user is on has all
the submenu inline tabs open. The onhover dropdown might be off. Now that i
think about it might make sense to turn these in submenu dropdowns as well.
> What do we need to do to get this through?
@mistercrunch Evan and were trying to figure out how to fix the overrides
that we have to put in the less file. This will most likely end up as a follow
up as this is not really a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
