villebro commented on a change in pull request #14547:
URL: https://github.com/apache/superset/pull/14547#discussion_r631577611
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/dashboard.helper.ts
##########
@@ -45,7 +45,9 @@ export interface ChartSpec {
export function getChartGridComponent({ name, viz }: ChartSpec) {
return cy
- .get(`[data-test="chart-grid-component"][data-test-chart-name="${name}"]`)
+ .get(`[data-test="chart-grid-component"][data-test-chart-name="${name}"]`,
{
+ timeout: 30000,
+ })
Review comment:
This was resolving very close to the default 5 secs, and apparently
started causing widespread flakiness on cypress. I bumped this to the 30s seen
a few lines below, now all tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
