kgabryje commented on a change in pull request #14547:
URL: https://github.com/apache/superset/pull/14547#discussion_r631608381
##########
File path: superset-frontend/spec/javascripts/datasource/fixtures.tsx
##########
@@ -29,7 +29,8 @@ export const columns: ColumnMeta[] = [
id: 516,
is_dttm: false,
python_date_format: null,
- type: ColumnType.DOUBLE,
+ type: 'DOUBLE',
Review comment:
Why don't we use `ColumnType` here anymore? Comment applies to all other
"ColumnType -> hardcoded string" changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
