villebro commented on a change in pull request #14547:
URL: https://github.com/apache/superset/pull/14547#discussion_r632370442
##########
File path: superset-frontend/spec/javascripts/datasource/fixtures.tsx
##########
@@ -29,7 +29,8 @@ export const columns: ColumnMeta[] = [
id: 516,
is_dttm: false,
python_date_format: null,
- type: ColumnType.DOUBLE,
+ type: 'DOUBLE',
Review comment:
`ColumnType` has been removed from `superset-ui/core` and replaced with
`string`, as it's the raw column type coming back from the database.
`ColumnType` was really just a generalization that mostly complied with ANSI
SQL types, but this was not a scalable solution, as the frontend mostly isn't
aware of which database is being used. As an example, the datatype `DOUBLE
PRECISION` wasn't being picked up on the frontend due to it being a datatype
that's mostly only available on dialects of Postgres. In corner cases two
datatypes with the same name can mean different things on different databases
(the boolean type on MySQL comes to mind, which is actually an integer). As
these are now handled in the backend and mapped to `GenericDataType`, that's
what we're now going to be using for the most part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
