AAfghahi commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r631941931
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -501,22 +529,79 @@ export default class ResultSet extends
React.PureComponent<
return <div />;
}
+ onAlertClose = () => {
+ this.setState({ alertIsOpen: false });
+ };
+
renderRowsReturned() {
- const { results, rows, queryLimit } = this.props.query;
- const limitReached = results?.displayLimitReached;
+ const { results, rows, queryLimit, limitingFactor } = this.props.query;
+ let limitMessage;
+ const isAdmin = this.props.user?.roles.hasOwnProperty('Admin');
+ const adminWarning = isAdmin
+ ? ' by the configuration DISPLAY_MAX_ROWS'
+ : null;
Review comment:
Yeah I explicitly need null here otherwise it returns undefined in the
Alert
```
description={t(
`The number of results displayed is limited to %s%s. Please add
additional limits/filters or download to csv to see more rows
up to
the %s limit. %s`,
rows,
adminWarning,
queryLimit,
)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
