AAfghahi commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r631942896
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -501,22 +529,79 @@ export default class ResultSet extends
React.PureComponent<
return <div />;
}
+ onAlertClose = () => {
+ this.setState({ alertIsOpen: false });
+ };
+
renderRowsReturned() {
- const { results, rows, queryLimit } = this.props.query;
- const limitReached = results?.displayLimitReached;
+ const { results, rows, queryLimit, limitingFactor } = this.props.query;
+ let limitMessage;
+ const isAdmin = this.props.user?.roles.hasOwnProperty('Admin');
+ const adminWarning = isAdmin
+ ? ' by the configuration DISPLAY_MAX_ROWS'
+ : null;
Review comment:
My original method was two separate Alerts one for admin and one for
non-admin but playing around with it, I tried this way and it worked and was
less lines. Happy to go back to the other method though if the construction
with && is DRY-er
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
