AAfghahi commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r633662947
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -501,36 +518,104 @@ export default class ResultSet extends
React.PureComponent<
return <div />;
}
+ onAlertClose = () => {
+ this.setState({ alertIsOpen: false });
+ };
+
renderRowsReturned() {
- const { results, rows, queryLimit } = this.props.query;
+ const { results, rows, queryLimit, limitingFactor } = this.props.query;
+ let limitMessage;
const limitReached = results?.displayLimitReached;
+ const isAdmin = !!this.props.user?.roles.Admin;
+ const displayMaxRowsReachedMessage = {
+ withAdmin: t(
+ `The number of results displayed is limited to %(rows)d by the
configuration DISPLAY_MAX_ROWS.
+ Please add additional limits/filters or download to csv to see more
rows up to the
+ the %(queryLimit)d limit.`,
+ { rows, queryLimit },
+ ),
+ withoutAdmin: t(
+ `The number of results displayed is limited to %(rows)d.
+ Please add additional limits/filters, download to csv, or contact an
admin
+ to see more rows up to the the %(queryLimit)d limit.`,
+ { rows, queryLimit },
Review comment:
oh interesting, ok I will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
