zuozhiw commented on PR #4495: URL: https://github.com/apache/texera/pull/4495#issuecomment-4323381113
Merging this big of a PR is never a good idea, in the meantime, I recognize that splitting PRs pose a significant overhead to the author. Give that 1) this is mostly setting up a new framework and does not affect any existing code, and 2) this new feature is largely experimental we do expect more frequent changes in this domain the future and 3) we are under very big deadlines of pushing out the release, I'm fine with leaving this big PR. High quality reviews often manifest in smaller and dedicated purposeful PRs. Two things I prefer to happen: 1) we need to mark this feature as experimental somewhere, either in PR description or somewhere in codebase, and 2) as the AI features continue to evolve, we should try to do a more in-depth review afterwards and in subsequent PRs, when we are not under time pressure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
