Xiao-zhen-Liu commented on PR #4495: URL: https://github.com/apache/texera/pull/4495#issuecomment-4322853524
I agree with all @Yicong-Huang 's three points. And we can separate codebase defaults from deployment behavior: we can let the AI feature be off by default in the codebase so it does not affect existing developers, but we can still let the deployments / releases turn the feature on. But I still think this current PR is too big. We have never had a single PR of this scale. Is there any plan of further dividing it? That being said, given our release deadline, **if all / most the 9K lines changes are self-contained and do not affect existing code**, we could do a shallow review now, focusing on testing the features and high-level issues, merge it first, then keep polishing it, as long as it does not regress the existing user experience. I also don't think the panel design is blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
