Yicong-Huang commented on PR #4495:
URL: https://github.com/apache/texera/pull/4495#issuecomment-4322615639
> Could the agent panel be integrated into the existing panel group instead?
It could still expand and appear as the default first panel, or have a shortcut
button for quick access—while remaining within the current panel structure.
>
> I think the left panel might be a good place.
I agree with Xinyuan in general. Let's think about this logically. we have
left, right and result panel. that are floating in the UI. it will be good to
reuse them. We have been following this practice for a long time, all the new
frames picks one existing panel to live on. Those including operator menu,
version, config, etc, on the left panel; operator property editor, port
property editor on the right panel, and result, debugger, console on the result
panel (did we rename it to bottom panel?).
To decide which panel to reuse, I always think which information are not
needed at the same time, most likely. For instance, I think it is less likely
needed for user to pick an operator from operator menu and look at the workflow
versions at the same time, thus operator menu and workflow version can be
placed on the same panel so they won't ever be shown at the same time. On the
other hand, I believe it is very common for user to view the property of an
operator and its result at the same time, thus we put operator property editor
and result frame on different panels. So that they can be displayed at the same
time.
With the same rule, when user is using AI, I think he/she would want to
1) look at operator property to understand what AI changed in an operator;
2) view the operator results or console logs, to see if AI's execution is
correct;
User would less likely want to check out the operator menu, version frame
while AI is running (this is my own assessment).
If the above assessment is true, left panel would be the best place to reuse
and place AI agents.
If not, then we could discuss whether we need the fourth panel (adding an AI
panel explicitly). Maybe to promote AI, it is worth to sit on its own panel as
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
