Xiao-zhen-Liu commented on issue #5318: URL: https://github.com/apache/texera/issues/5318#issuecomment-4676126412
Approach looks right to me — go with the `.browser.spec.ts` split. It lines up with the convention already on `main` (jsdom excludes `**/*.browser.spec.ts`, `test-browser` includes it, and `code-editor.component.browser.spec.ts` is an existing precedent), and since the frontend build job runs `gui:test-browser` as a step (`build.yml`, "Run frontend browser-mode tests"), moving the six tests there genuinely restores them under an enforced CI run rather than just uncommenting them. Agree on skipping the jsdom-polyfill alternative — not worth chasing. Two things to fold into the same PR: 1. Once the mouse-event tests move out, drop the explicit `workflow-editor.component.spec.ts` entry from the `test-browser` `include` in `angular.json` — otherwise the remaining jsdom-friendly tests run twice (jsdom + real Chrome). 2. The split means two `TestBed` setups for the same component; please share a common setup helper so they don't drift. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
