eugenegujing commented on code in PR #6492: URL: https://github.com/apache/texera/pull/6492#discussion_r3625377425
########## amber/src/test/python/core/architecture/rpc/test_async_rpc_server.py: ########## @@ -0,0 +1,511 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import asyncio + +import grpclib.const +import pytest +from grpclib.const import Cardinality + +from core.architecture.rpc import async_rpc_server as async_rpc_server_module +from core.architecture.rpc.async_rpc_server import AsyncRPCServer +from core.models.internal_queue import DCMElement, InternalQueue +from core.util import get_one_of, set_one_of +from proto.org.apache.texera.amber.core import ( + ActorVirtualIdentity, + ChannelIdentity, +) +from proto.org.apache.texera.amber.engine.architecture.rpc import ( + AsyncRpcContext, + ControlError, + ControlInvocation, + ControlRequest, + ControlReturn, + EmptyRequest, + ErrorLanguage, + ReturnInvocation, + StringResponse, +) + + +def _make_handler(func) -> grpclib.const.Handler: + """Builds a real grpclib Handler namedtuple around an async callable. + + AsyncRPCServer only ever touches `.func`, but using the real namedtuple + keeps the stub shape identical to what AsyncRPCHandlerInitializer yields. + """ + return grpclib.const.Handler( + func, Cardinality.UNARY_UNARY, ControlRequest, ControlReturn + ) Review Comment: fixed with my commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
