aglinxinyuan commented on code in PR #6797:
URL: https://github.com/apache/texera/pull/6797#discussion_r3649840118
##########
common/config/src/test/scala/org/apache/texera/common/config/PekkoConfigSpec.scala:
##########
@@ -76,4 +76,28 @@ class PekkoConfigSpec extends AnyFlatSpec with Matchers {
}
config.getString("pekko.stdout-loglevel") shouldBe "INFO"
}
+
+ it should "always expose a loglevel pekko accepts, whatever spelling the env
used" in {
Review Comment:
Good catch — done in b06b189730. Replaced it with your formulation: the
pure-function invariant over the combined logback+pekko vocabulary
(`OFF/ERROR/WARN/WARNING/INFO/DEBUG/TRACE/ALL` all normalize into pekko's
accepted set), plus an env-insensitive plumbing check — whatever the env
supplied, the exposed `pekko.loglevel` must equal its normalized form (identity
for unknown spellings, so it can't false-positive; CI's WARN exercises it for
real). Verified 8/8 locally with the env unset, with WARN, and with FATAL —
your counterexample, which did fail before this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
