Yicong-Huang commented on code in PR #6797:
URL: https://github.com/apache/texera/pull/6797#discussion_r3649819210
##########
common/config/src/test/scala/org/apache/texera/common/config/PekkoConfigSpec.scala:
##########
@@ -76,4 +76,28 @@ class PekkoConfigSpec extends AnyFlatSpec with Matchers {
}
config.getString("pekko.stdout-loglevel") shouldBe "INFO"
}
+
+ it should "always expose a loglevel pekko accepts, whatever spelling the env
used" in {
Review Comment:
This invariant doesn't hold for spellings outside the translated vocabulary:
with e.g. `TEXERA_SERVICE_LOG_LEVEL=FATAL` in the environment,
`normalizePekkoLogLevel` passes the value through unchanged and this assertion
fails — an env-sensitive test in a file whose header comment establishes
guarding exactly this kind of assertion. Consider asserting the pure-function
invariant instead: for each spelling in the known logback + pekko vocabulary
(`OFF/ERROR/WARN/WARNING/INFO/DEBUG/TRACE/ALL`), `normalizePekkoLogLevel(...)`
lands in pekko's accepted set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
