Yicong-Huang commented on code in PR #6797:
URL: https://github.com/apache/texera/pull/6797#discussion_r3648904301
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorRefMappingService.scala:
##########
@@ -76,13 +76,13 @@ class PekkoActorRefMappingService(actorService:
PekkoActorService) extends Amber
def removeActorRef(id: ActorVirtualIdentity): Unit = {
if (actorRefMapping.contains(id)) {
val ref = actorRefMapping.remove(id).get
- logger.warn(s"actor $id is not reachable anymore, it might have crashed.
old ref = $ref")
+ logger.debug(s"removed actor ref for $id. old ref = $ref")
Review Comment:
I agree it may have some confusion here. but for this one, it is inside the
reference mapping service, it has no idea about actor's life cycle. it only
knows a certain actor is not reachable. it does not know if it is terminated as
expected or crashed. that's why the original message says "might have crashed".
Let's not change it to `removed` it sounds intentional.
We can just say "actor xx is not reachable anymore. old ref xxx", how about
this? we do not infer whether it is crashed or intentionally removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
