Yicong-Huang commented on code in PR #7623:
URL: https://github.com/apache/texera/pull/7623#discussion_r3789082040
##########
.github/workflows/build.yml:
##########
@@ -86,7 +86,20 @@ jobs:
frontend:
if: ${{ inputs.run_frontend }}
runs-on: ${{ matrix.os }}
+ # Only the "Install dependency" step below is bounded, so a spec that
+ # truly hangs would otherwise run to GitHub's implicit 6h cap — billed at
+ # 10x on the macOS leg. Recent green runs take 4-12 minutes and install
+ # alone may take 20, so 30 bounds a hang while still absorbing a cold
+ # yarn cache on a slow runner.
Review Comment:
The 20 here is the `Install dependency` step's own budget (`:142`), not an
observed duration — install measured 37-74s across this PR's three legs.
The conclusion then doesn't follow: if install did approach 20, the
remaining steps still need 8-9.5 minutes (measured), putting the job at 28-29.5
against the 30 cap. No absorption is left in exactly the
cold-cache-on-a-slow-runner case the sentence names.
The value is fine at 2.8x the worst leg; sizing it from observed runs like
`amber-integration` (`:375-376`) makes the sentence carry it.
```suggestion
# 10x on the macOS leg. Recent green legs run 8-11 minutes end to end, so
# 30 leaves roughly 3x headroom for a cold yarn cache on a slow runner
# without masking a hang.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
