aglinxinyuan commented on code in PR #7623:
URL: https://github.com/apache/texera/pull/7623#discussion_r3840945052
##########
.github/workflows/build.yml:
##########
@@ -86,7 +86,24 @@ jobs:
frontend:
if: ${{ inputs.run_frontend }}
runs-on: ${{ matrix.os }}
+ # Only the "Install dependency" step below is bounded, so a spec that
+ # truly hangs would otherwise run to GitHub's implicit 6h cap — billed at
Review Comment:
You're right, and I read the policy rather than take it from the thread:
GitHub's [runner
docs](https://docs.github.com/en/actions/reference/runners/github-hosted-runners)
say use of the standard GitHub-hosted runners is free and unlimited on public
repositories. `macos-latest` is a standard runner, `apache/texera` is public,
so the 10x is a billed-minutes rate for private repos and buys nothing here.
Removed from the comment and from the matching description row in 8217f1e1.
The bound that replaced it is the one you pointed at. `orgs/apache` reports
the `enterprise` plan, and [Actions
limits](https://docs.github.com/en/actions/reference/limits) gives that tier:
| Bound | Enterprise |
| --- | --- |
| total concurrent jobs | 500 |
| **concurrent macOS jobs** | **50** |
macOS is the scarce one by an order of magnitude, and that 50 is shared
across the whole `apache` org, not this repo. So a hung leg holds one of fifty
slots every Apache project draws from for six hours — same case for the cap,
without a cost that isn't ours to pay.
```
- ... implicit 6h cap — billed at 10x on the macOS leg.
+ ... implicit 6h cap, holding one of the 50 concurrent macOS jobs
+ the whole `apache` org shares for that window.
```
##########
frontend/TESTING.md:
##########
@@ -47,6 +47,7 @@ For repo-wide testing philosophy (TDD, characterization
tests, "every test must
| Coverage | `@vitest/coverage-v8`
|
| Test setup | `src/test-zone-setup.ts` wraps `it`/`test` in an
Angular ProxyZone (Vitest does not provide one and Angular's `fakeAsync`
requires it) |
| Globals | `globals: true` in `vitest.config.ts`, so
`describe / it / expect / vi / beforeEach` come from the runtime — no per-file
imports |
+| Timeouts | Raised over Vitest's defaults because macOS CI
runners stall for seconds at a time (#6073, #7713). jsdom: 20s per test / 30s
per hook (`vitest.config.ts`, defaults 5s/10s). Browser mode: 30s per test
(`vitest.browser.config.ts`), hooks left at the 30s `browser.enabled` already
resolves — its per-test default is 15s |
Review Comment:
Taken verbatim in 8217f1e1 — `the 30s default that` gives the trailing
clause its noun. Thanks for catching it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
