yrenat commented on code in PR #6046:
URL: https://github.com/apache/texera/pull/6046#discussion_r3835513670
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/ComputingUnitManagingService.scala:
##########
@@ -32,9 +32,44 @@ import org.apache.texera.service.resource.{
ComputingUnitManagingResource,
HealthCheckResource
}
+import
org.apache.texera.service.resource.ComputingUnitManagingResource.TerminatedComputingUnitInfo
+import org.slf4j.LoggerFactory
import java.nio.file.Path
+import java.util.concurrent.TimeUnit
class ComputingUnitManagingService extends
Application[ComputingUnitManagingServiceConfiguration] {
+ private val logger =
LoggerFactory.getLogger(classOf[ComputingUnitManagingService])
+
+ private[service] def initSqlServer(
+ connect: (String, String, String) => Unit = SqlServer.initConnection
+ ): Unit =
+ connect(
+ StorageConfig.jdbcUrl,
+ StorageConfig.jdbcUsername,
+ StorageConfig.jdbcPassword
+ )
+
+ private[service] def registerIdleComputingUnitCleanup(environment:
Environment): Unit =
Review Comment:
sorry for this mistake. I now merged the cleanup scheduler setup into a
single `registerIdleComputingUnitCleanup` method with injectable defaults for
tests, and kept the scheduled action itself in `runIdleComputingUnitCleanup`.
The duplicate overloads were removed, and the scheduler tests now use this
single entry point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
